Add SupRemo in Remote_Mgmt #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dxdemetriou
added a commit
to dxdemetriou/glpi
that referenced
this pull request
Jul 13, 2022
Created a pull request on GLPI-AGENT: glpi-project/glpi-agent#179 Referenced request: glpi-project/glpi-agent#35
trasher
pushed a commit
to glpi-project/glpi
that referenced
this pull request
Jul 15, 2022
* Add SupRemo in Remote management Created a pull request on GLPI-AGENT: glpi-project/glpi-agent#179 Referenced request: glpi-project/glpi-agent#35 * Update Item_RemoteManagement.php
g-bougard
requested changes
Jul 15, 2022
There was a problem hiding this comment.
Hi @dxdemetriou
thank you for your submission.
I think you made few mistakes with the registry path. Can you check my comments and fix them ?
I also suggest you few other changes.
g-bougard
reviewed
Jul 15, 2022
Don't pass osname here but directly use OSNAME to call right sub Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Remove this with the simpler code I propose to call the right sub Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
maxdepth Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
maxdepth Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Here you must handle correctly the case clientid is not found to avoid an error on sprintf() call and just ignore the inventory. Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
g-bougard
approved these changes
Aug 8, 2022
|
Thank you for your contribution ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #35