Fix deletions using joins; fixes #5478 #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trasher
approved these changes
Mar 1, 2019
yllen
approved these changes
Mar 1, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
Apr 17, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
Apr 23, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 6, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 7, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 7, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 7, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 7, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 15, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 15, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 16, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 20, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 21, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 27, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 27, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 27, 2019
trasher
added a commit
to trasher/glpi
that referenced
this pull request
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table name is mandatory beween DELETE and FROM when deletion is using joins (and is just useless when only one table is used).
I assume that we only want to delete data from the main table.