Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"vendor" missing in archive. #848

Closed
remicollet opened this issue Aug 2, 2016 · 11 comments
Closed

"vendor" missing in archive. #848

remicollet opened this issue Aug 2, 2016 · 11 comments
Assignees

Comments

@remicollet
Copy link
Contributor

In glpi-0.9.1RC2 the "vendor" directory is missing.

@remicollet
Copy link
Contributor Author

remicollet commented Aug 2, 2016

More: permissions are strange (also affects 0.90), directory should be rwxr-xr-x

$ tar tvzf /tmp/glpi-9.1RC2.tar.gz  | grep "^d"
drwx------ adelaunay/adelaunay     0 2016-07-27 14:45 glpi/files/_cron/
drwx------ adelaunay/adelaunay      0 2016-07-27 14:45 glpi/lib/tiny_mce/plugins/visualblocks/css/
drwx------ adelaunay/adelaunay      0 2016-07-27 14:45 glpi/lib/tiny_mce/plugins/media/
drwx------ adelaunay/adelaunay      0 2016-07-27 14:45 glpi/lib/jqueryplugins/jquery-gantt/img/
drwx------ adelaunay/adelaunay      0 2016-07-27 14:45 glpi/lib/
drwx------ adelaunay/adelaunay      0 2016-07-27 14:45 glpi/install/mysql/
...

@orthagh
Copy link
Contributor

orthagh commented Aug 26, 2016

i pushed a new archive for RC2 with theses fixes

@orthagh orthagh closed this as completed Aug 26, 2016
@ddurieux
Copy link
Contributor

So it's a RC3 ...

@orthagh
Copy link
Contributor

orthagh commented Aug 26, 2016

No, i replaced the archive for the rc2 tag with the rc2 files (and added the missing folder and fix the permission).

@ddurieux
Copy link
Contributor

That I mean, you have modified a released version, so you may not update it but create a RC3 ;)

@mohierf
Copy link

mohierf commented Aug 26, 2016

I do agree with @ddurieux ... you should not release a "false" new RC2 but an RC3 version ...

@orthagh
Copy link
Contributor

orthagh commented Aug 26, 2016

I don't know if you really see what i mean, i didn't change the released version, the tag still at the same place. it's the published archive (and not the release), i fixed
I don't want anyone to keep missing essentially files when testing current rc (in fact, it's broken).

Anyway, a RC3 is planned for soon, and i'll try to avoid bad archives

@ddurieux
Copy link
Contributor

It's pre-release (it's same) and it's tagged, so no you never update an archive annouced/released/pre-released 4 weeks ago with update files, so it will be increased with a new tag + so RC3

@orthagh
Copy link
Contributor

orthagh commented Aug 26, 2016

ok for the delay (i shutdown all communications this last weeks), it's not the best.

Let's close this discussion, i'll release a RC3 next week.

@mohierf
Copy link

mohierf commented Aug 26, 2016

Anyone that already got the archive will have a bad RC2 ... thinkin he got the good one you just modified. I hope those people will not loose too many time on problems they should have had :(

@orthagh
Copy link
Contributor

orthagh commented Aug 26, 2016

We agree.
the problem: they had a message ask them to install dependencies with composer (see #896).
The error is not really blocking, but annoying.

The today fix is temporary, i have another issues to review/fix before shipping a new rc (a few days of work, i think).
Waiting for, i though it was good to fix archive to avoid this issue. For the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants