New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build when come from fork and other issues #29

Merged
merged 3 commits into from Oct 26, 2017

Conversation

Projects
2 participants
@rafaelje
Collaborator

rafaelje commented Oct 26, 2017

Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: Conventional Commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue #

Parameters (query string) for Get Sub Items endpoint
close: #23

Parameters (query string) for Get An Item endpoint
close: #22

Parameters (query string) for Get All Items endpoint
close: #21

License Header
close: #14

New Group ID, Artifact ID and Maven repository
close: #10

Publish to Bintray/JCenter/Maven
close: #3

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

rafaelje added some commits Oct 26, 2017

@ajsb85 ajsb85 self-requested a review Oct 26, 2017

@ajsb85 ajsb85 added bug build ci labels Oct 26, 2017

@ajsb85 ajsb85 added this to the 1.0 milestone Oct 26, 2017

@ajsb85 ajsb85 removed bug build labels Oct 26, 2017

@rafaelje rafaelje changed the title from [WIP] Fix build when come from fork and other issues to Fix build when come from fork and other issues Oct 26, 2017

@rafaelje

This comment has been minimized.

Show comment
Hide comment
@rafaelje

rafaelje Oct 26, 2017

Collaborator

@ajsb85 please review this PR when you can, thanks!

Collaborator

rafaelje commented Oct 26, 2017

@ajsb85 please review this PR when you can, thanks!

@ajsb85

ajsb85 approved these changes Oct 26, 2017

Reviewed

@ajsb85 ajsb85 merged commit 0ee3149 into glpi-project:develop Oct 26, 2017

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@rafaelje rafaelje deleted the rafaelje:fix/build branch Oct 26, 2017

@ajsb85 ajsb85 added this to Done in Library May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment