Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki Articles of Code Examples #26

Merged
merged 2 commits into from
Nov 6, 2017
Merged

Conversation

Naylin15
Copy link
Contributor

@Naylin15 Naylin15 commented Nov 5, 2017

Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: Conventional Commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue #20

What is the new behavior?

Wiki article of code examples, one for the async - await functions and the other for the promises

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Hi, @ajsb85

This PR adds the wiki articles of the code examples

@ajsb85 ajsb85 self-requested a review November 6, 2017 11:39
@ajsb85 ajsb85 modified the milestones: 2.0, 1.0 Nov 6, 2017
Copy link
Contributor

@ajsb85 ajsb85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@ajsb85 ajsb85 merged commit 9e0754f into glpi-project:gh-pages Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants