Fix imported files not causing watch mode updates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inlines the `compile` function from glslify with a modification to also return dependencies so they can be passed to `addWatchFile`
|
Related discussion: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
viteorrollup --watch, editing a shader file that is only imported by another shader file via glslify doesn't trigger a rebuild. This PR fixes that. See vitejs/vite#1614 (comment).There is some duplication caused by inlining the compile function from glslify, which is required to keep supporting the glslify API options mentioned in this project's README. We can coordinate with the glslify repo to remove this duplication in the future.
This fix only takes effect if
addWatchFileworks, i.e. Vite >=4 or Rollup not on Linux.