New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix netstandard2 + .NET 4.6.2 #235
Conversation
I wonder if it's OK to switch AppVeyor to VS2017 image? |
Switching requires unit test fixes from the other PR anyways so that depends if you're going to accept it (in which case that goes first) or not (then I'll cherry-pick that into here). |
This one LGTM, I would support merging it before the other, which is too big to be reviewed quickly. Thx ! |
I've cherry-picked relevant pieces from my master - tests should be OK now. The other PR consists mostly of abandoned 0.10 branch - I have no idea why it was abandoned in the first place (lack of time I guess?) because it's extremely close to actually working on 0.10 cecil (sans Win32 resource handling). |
Thanks ! will look at the cecil 0.10 branch when I get some time, would be great if you could rebase it. |
OK, I've rebased the other pull request. |
Hi, I think I'm hitting these issues when trying to merge asp.net core assemblies. Would it be possible to push a new release to nuget? Thank you for this awesome project, really helpfull! |
@0x53A I'm using package id avostres.ilrepack as a stopgap solution - it includes this PR and the bigger 0.10 cecil PR |
<AppDesignerFolder>Properties</AppDesignerFolder> | ||
<RootNamespace>DotNet462NetStandard2</RootNamespace> | ||
<AssemblyName>DotNet462NetStandard2</AssemblyName> | ||
<TargetFrameworkVersion>v4.6.2</TargetFrameworkVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, for .NET standard it should actually be
<TargetFramework>netstandard2.0</TargetFramework>
No? Otherwise it's just .NET 4.6.2
Also, the structure of the project should be different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this PR says it's about "netstandard2 support layer for .NET 4.6.1-4.7.1"
netstandard2 support layer for .NET 4.6.1-4.7.1 abuses redirects - it has both chained redirects (System.Object is redirected from System.Runtime.dll to netstandard.dll to mscorlib.dll) and duplicated redirects (System.Data.* types are redirected to System.Data.dll by both System.Data.Common.dll and netstandard.dll).
First case ends up with Assembly.GetTypes() throwing due to missing types and second case ends up with startup crash due to duplicated types.