Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting for SP API models' noncompliance with actual SP API responses #21

Merged

Conversation

codelinde
Copy link
Collaborator

Correcting for SP API models' noncompliance with actual SP API responses observed in production (SellerFreightClass, UnitOfMeasurement); including tests to support altered/custom behavior.

…ses observed in production (SellerFreightClass, UnitOfMeasurement); including tests to support altered/custom behavior.
Copy link
Collaborator

@jpsilkjr86 jpsilkjr86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I like the combined allowable enums approach, which will protect against the possibility of Amazon releasing a new version that corrects the production responses to comply with their own Swagger models.

@codelinde codelinde merged commit 120644d into main Feb 3, 2024
@codelinde codelinde deleted the feature/correct-non-compliant-model-serialization-behavior branch April 2, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants