New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Options widget improvements #34
Conversation
Thanks, this looks very great. I found that the py.test failed with |
I just realized there is a change missing here, will commit later today (and that will fix error). I also want to make a few other improvements to the options widget, which I'll also make later today. |
I accidentally opened this from a branch I pushed to this repo instead of my repository... I'll delete the branch from this repo once it's merged. |
2e317a2
to
b563846
Compare
@PennyQ @maxwelltsai - I've done some significant refactoring to try and address both #25 and #35 as well as make sure things are better separated. The options widget now includes a label giving the stretch value that auto-updates, and the ability to set that stretch value manually. In addition, the component of the data can now be selected, and the correct axis labels are used (instead of just RA/DEC/VEL). The canvas-specific code setting e.g. camera and data parameters has been refactored and is now in the vispy widget rather than in the options widget. The options widget is kept as simple as possible and simply triggers a refresh from the data viewer when any options are updated. Before, the options widget had to go and modify the camera elements, which is not ideal. The diff is going to be hard to read, but I encourage you to look at the code in the branch: https://github.com/glue-viz/glue-3d-viewer/tree/options-improvements/vispy_volume And also feel free to try out that branch to check if anything is broken (if you prefer, we can merge and then you can test it out, I'll leave that up to you). |
The options widget now includes a label giving the stretch value that auto-updates, and the ability to set that stretch value manually. In addition, the component of the data can now be selected. The canvas-specific code setting e.g. camera and data parameters has been refactored and is now in the vispy widget rather than in the options widget. The options widget is kept as simple as possible and simply triggers a refresh from the data viewer when any options are updated.
34aed98
to
acc6dfc
Compare
@astrofrog This looks so great, very looking forward to seeing it be merged. |
@PennyQ - Thanks for reviewing! Will merge now - I hope this doesn't cause to many conflicts for your changes relating to the axes! |
@PennyQ @maxwelltsai - this tidied up the options widget a little and fixes #25