Add export tools for bqplot viewers #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #41. This is accomplished by some modification to the common functionality (for the image viewer, in particular), to use state as input whenever possible. Additionally, this adds export tools for the bqplot scatter, histogram, profile, and image viewers. These export tools use the viewer's output widget to create a file chooser dialog in order to the user to select the location of the HTML output.
Edit: I should note that I also tried implementing the file choosing dialog using
tkinter(see this branch), but it behaved very badly for me on macOS even with some attempts to work around the issues.