Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishing workflow to GH Actions #86

Merged
merged 3 commits into from
May 19, 2022

Conversation

dhomeier
Copy link
Contributor

@dhomeier dhomeier commented Apr 7, 2022

Description

Follow-up to #82 adding a publish_pure_python job.

.github/workflows/ci_workflows.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #86 (cf34c3f) into main (101e94a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage   71.97%   71.97%           
=======================================
  Files          18       18           
  Lines         860      860           
=======================================
  Hits          619      619           
  Misses        241      241           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101e94a...cf34c3f. Read the comment docs.

@dhomeier
Copy link
Contributor Author

dhomeier commented Apr 7, 2022

Any thoughts why the test_extras are not installing their PyQt dependencies? Might be because pip install QtPy by itself does not install a working backend, so maybe the install_requires explicitly need PyQt5 (or something like PyQt5 | PySide2)?

@dhomeier dhomeier force-pushed the gh-workflows branch 5 times, most recently from 7138678 to 4a93a44 Compare April 7, 2022 16:28
@dhomeier
Copy link
Contributor Author

dhomeier commented Apr 7, 2022

I suppose there is no subset of tests working without a backend, since the core package cannot even be imported?
Shall I cut the tests until it is possible to set up a headless display in the publishing tests?

@astrofrog
Copy link
Member

Yes can we just make the publish job be contingent on the main test matrix passing instead?

@dhomeier
Copy link
Contributor Author

dhomeier commented Apr 7, 2022

Oh; got the test_command working now (see comment in matrix).

Nonetheless having one job being contingent on another would in fact be useful (like for the minimal/extended test configurations), but I haven't found anything on how to do this so far.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks! I'll send a message later showing how to have dependent jobs

@astrofrog
Copy link
Member

I'll merge this for now, we can do the dependent stuff later

@astrofrog astrofrog merged commit 608d879 into glue-viz:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants