Create table layers as non-selectable in pywwt #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
disable-selectable
branch
from
98f196d
to
47ac835
Compare
|
Rebased to get rid of the changelog entry and see if CI passes now |
astrofrog
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the glue-wwt table layer to be aware of the changes in WorldWideTelescope/pywwt#334. Recent versions of pywwt have the ability to allow the user to select sources from a catalog via a mouse click, and bring that information into Python. Since we aren't using this in glue-wwt, we don't want the cursor change that accompanies mousing over a point, and so this PR creates the layer with
selectable=Falsewhen the option exists. We should also see a performance improvement when there are a lot of points displayed, since the pywwt JS does some calculations to determine when the cursor is over a selectable point. Note that this PR doesn't prevent us from using selectability in the future in e.g. some selection tool - the layer'sselectableattribute can be modified after creation.