force the data collection view to update when data is changed

[Jerry-Ma]

For some reason, the data collection tree view does not update when new data is loaded.

[astrofrog]

@Jerry-Ma - thanks! Could you add a regression test, or provide some code that illustrates the issue?

[Jerry-Ma]

@astrofrog The issue can be replicated by doing the following:

1. start glue
2. load data from File->Load Dataset or click the "folder" button

What is expected:
The loaded dataset shows in the layer tree view
What is happening:
The loaded dataset does not show. In the layer tree view, it remains showing "Data" and "Subsets"

I am using the latest development version of glue, and OSX 10.12.3

[astrofrog]

@Jerry-Ma - thanks - what kind of data are you reading in? Also, can you send me the output of Help -> Version Information? (there is a copy to clipboard button there)

[Jerry-Ma]

@astrofrog

I tried fits image, ascii catalog, fits catalog, and png image, and the issue is persistent for all of them.

The issue is also present when just run

cd glue/core/qt
python data_collection_model.py

The test tree view will show a wrong child called "Data" under the "Data" node, as shown in the image:

I checkout-ed v0.10.1 (which has the issue present), and here is the Help -> Version Information:

Glue: 0.10.1
PyQt4: Not installed
PyQt5: PyQt: 5.7.1 - Qt: 5.7.1
PySide: Not installed
qtpy: 1.1.2
setuptools: 32.1.0
numpy: 1.11.3
matplotlib: 1.5.3
pandas: 0.19.2
astropy: 1.3
dill: 0.2.6
h5py: 2.6.0
xlrd: 1.0.0
glue_vispy_viewers: 0.7.2
IPython: 5.1.0
qtconsole: 4.2.1
ipykernel: 4.5.2
traitlets: 4.3.1
pygments: 2.1.3
zmq: 16.0.2
scipy: 0.18.1
skimage: 0.12.3
pyavm: Not installed
spectral_cube: Not installed
astrodendro: Not installed
mock: 2.0.0
pytest: 3.0.5
plotly: Not installed

[astrofrog]

Thanks for the information, I'll see if I can reproduce the issue. One last question: which version of MacOS X are you using? And how did you install glue? Are you using Anaconda?

[Jerry-Ma]

@astrofrog
MacOS version:

  System Version:	macOS 10.12.3 (16D32)
  Kernel Version:	Darwin 16.4.0

I installed glue by doing git clone and cd <glue_dir> && pip install .. No anaconda is involved.

[astrofrog]

@Jerry-Ma - thanks! One final question, how did you install Qt/PyQt? (I don't see the issue locally, so I just want to make sure I understand under what circumstances the fix is needed)

[Jerry-Ma]

@astrofrog
My PyQt is installed from homebrew:

brew install pyqt5

It pulls automatically the homebrew version of Qt5 as dependency.

[astrofrog]

@Jerry-Ma - thanks, I'll investigate further. I can't reproduce this on MacOS X 10.11 with brew, conda, or MacPorts, so I'll try and get hold of a 10.12 machine to test. I need to understand whether this is a bug in Qt5 on MacOS X 10.12, or at least why the behavior has changed before we can add this workaround.

[Jerry-Ma]

@astrofrog
No problem. I am also pretty much suspecting this being a bug specific to my system, because I remember it worked well when I ran on my linux box.

[astrofrog]

@Jerry-Ma - are you still running into this on the one system?

[Jerry-Ma]

@astrofrog Until recently I picked up glue again and now I am running glue version of

0.12.0.dev03936

on my macOS

10.12.6 (16G29) Kernel Version:	Darwin 16.7.0

Unfortunately, the data collection view is still not updating. Have you got a chance of testing glue on a mac 10.12 with homebrew Qt5?

[astrofrog]

@Jerry-Ma - sorry for the delay, I've finally had a chance to try this out and can't reproduce it on MacOS X 10.13 with:

/usr/local/Cellar/pyqt/5.10.1 (985 files, 44.9MB) *
  Poured from bottle on 2018-04-25 at 16:38:38

Can you try updating to the latest PyQt5 version and latest developer version of glue to see if there are still any issues?

[Jerry-Ma]

@astrofrog Thank you very much on following this up. Yes, with the updated version of Qt the problem is gone. So I guess you can go ahead and close the issue.

[astrofrog]

@Jerry-Ma - thanks for confirming this!