-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NDData support as data factories to glue #2164
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2164 +/- ##
==========================================
- Coverage 87.87% 87.87% -0.01%
==========================================
Files 246 247 +1
Lines 22724 22788 +64
==========================================
+ Hits 19969 20024 +55
- Misses 2755 2764 +9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This introduces a very big change which is to add mask and uncertainty to the main data object, which I don't think we want to do. In particular, each attribute could in principle have an uncertainty. I think a better approach would be for now to store the mask and uncertainty in attributes with special names which then doesn't require any changes to the main data class.
This also overlaps discussion wise with glue-viz/glue-astronomy#17 - which is about translating NDData <-> Data and once that is complete we can leverage that to simplify the FITS as NDData reader. However, I think that to make things easier to manage, this data factory here should also be added to glue-astronomy, not glue-core (to keep all the NDData stuff in a single place)
More generally, I wonder if we should just be doing |
Sure, let me make the changes soon |
Description
Add
astropy.nddata
support as data factories in order to offer an alternative means to load more specific data types, such as FITS files, but using theNDData
, making the manipulation ofunits
,mask
,uncertainty
, andmeta
of any FITS data more manageable in the context ofglue
.