Started adding support for PyQt5 #3
Conversation
|
@ChrisBeaumont - I'll leave this open for a few days in case you want to review. But with this and with a few small changes elsewhere in glue, I can get glue to open with PyQt5. |
|
|
||
| def reload_qt(): | ||
|
|
There was a problem hiding this comment.
Can you explain what this does in a docstring? I assume this is only meant to be used to reimport the same Qt binding (since trying to import several leads to trouble)
There was a problem hiding this comment.
Will do - basically it's a cleaner way than doing reload(qt_helpers) - if you change the environment variable for example, you can call this and it will load the qt bindings again with a different library (e.g. pyside instead of pyqt4) if needed.
There was a problem hiding this comment.
Does that work though? I thought loading two bindings in the same process was prone to crashing
There was a problem hiding this comment.
It seems to work according to test_submodule_import. What doesn't work though is importing PyQt4 then importing PyQt5. But PyQt4 <-> PySide seems to work.
|
@ChrisBeaumont - I added a docstring for |
|
Huh -- I seem to recall this behaving badly (though maybe this was because my PySide/PyQt4 versions were linked against different Qt libraries. Who knows). One more question -- can you actually pull up a QWidget after calling reload? If so, then I'm fine with the function. If that breaks (and reload is only useful as a test utility since the tests don't actually instantiate widgets or applications), then reload() should probably live as a non-public function inside the test file. (Sorry, I'd check myself but I only have one Qt binding set up ATM) |
|
@ChrisBeaumont - ah, good point, will try that out! |
|
@ChrisBeaumont - it seems to work properly, see new test in 7358dd8 which works fine. However, I got segmentation faults if I didn't |
|
@ChrisBeaumont - does this look ok now, or do you think I should make the reload function private anyway? |
|
Looks good! On Friday, June 19, 2015, Thomas Robitaille notifications@github.com
|
|
Thanks! |
Started adding support for PyQt5
This starts to add support and tests for PyQt5. There is a subtlety however, which is that even conda doesn't complain if I install PyQt5 and PyQt4/Pyside in a same environment, PyQt5 is unable to create a QApplication in this case because the environment contains both the Qt4 and Qt5 libraries and it gets confused.
In addition, I found that some strange behaviors were due to the use of reload in tests, which doesn't actually clean up
sys.meta_pathwhich ends up containing many ImportDenier instances (because when it reloads the module it adds a new hook without removing the old one, and worse, all old instances are instances of a different class since it redefines the ImportDenier class every time). Anyway, because this is complex, I've tidied it up so that we don't actually callreloadbut intead have areload_qtthat ensures everything is clean and avoids this kind of issue.