Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change chrono from_* methods to from_*_opt #1000

Merged
merged 2 commits into from
Nov 12, 2022
Merged

Change chrono from_* methods to from_*_opt #1000

merged 2 commits into from
Nov 12, 2022

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Nov 12, 2022

No description provided.

@ever0de ever0de added the improvement Improvements for existing features label Nov 12, 2022
@ever0de ever0de self-assigned this Nov 12, 2022
@coveralls
Copy link

coveralls commented Nov 12, 2022 •
edited

Pull Request Test Coverage Report for Build 3450873516

  • 247 of 247 (100.0%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.388%
Totals Coverage Status
Change from base Build 3436012993: 0.002%
Covered Lines: 39909
Relevant Lines: 40563
💛 - Coveralls

@ever0de ever0de force-pushed the fix/change-chrono-from-methods-to-from_-opt branch from 9a4a58e to 210ba70 Compare November 12, 2022 11:28
panarch
panarch approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice!
Also looks good to specify the exact version of chrono.
Thanks a lot 👍

@panarch panarch merged commit 15e8a08 into gluesql:main Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ever0de @coveralls @panarch