Replace double quotes to identifier
#1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ever0de
reviewed
Nov 12, 2022
core/src/data/interval/mod.rs
Outdated
| @@ -287,7 +287,10 @@ impl Interval { | |||
| format!("{:?}", to), | |||
| ) | |||
| .into()), | |||
| (None, _) => Err(IntervalError::Unreachable.into()), | |||
| (None, _) => { | |||
| println!("here"); | |||
There was a problem hiding this comment.
Suggested change
| println!("here"); |
ever0de
reviewed
Nov 12, 2022
core/src/data/interval/string.rs
Outdated
Comment on lines
18
to
19
| println!("{parsed:?}"); | ||
| // println!("{leading_field:?}:{last_field:?}"); |
There was a problem hiding this comment.
Suggested change
| println!("{parsed:?}"); | |
| // println!("{leading_field:?}:{last_field:?}"); |
Pull Request Test Coverage Report for Build 3451045591
💛 - Coveralls |
devgony
force-pushed
the
doubleQuotes-identifier
branch
from
efb30ed
to
398602f
Compare
panarch
approved these changes
Nov 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Currently, Both
double quotesandsingle quotesevaluated asliteral string.From now,
Double quoteswill be evaluated asidentifier.Before
After
Todo