Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Tester::new async #1004

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Make Tester::new async #1004

merged 3 commits into from
Nov 16, 2022

Conversation

ShaddyDC
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Nov 16, 2022 •
edited

Pull Request Test Coverage Report for Build 3479659193

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • 43 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 98.428%
Files with Coverage Reduction New Missed Lines %
core/src/executor/alter/table.rs 7 94.26%
core/src/data/value/binary_op/i64.rs 36 96.7%
Totals Coverage Status
Change from base Build 3468343674: -0.02%
Covered Lines: 39751
Relevant Lines: 40386
💛 - Coveralls

ever0de
ever0de reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also change the storage in pkg/javascript/* (see CI https://github.com/gluesql/gluesql/actions/runs/3472026404/jobs/5811085354)

storages/memory-storage/tests/memory_storage.rs Outdated Show resolved Hide resolved
storages/shared-memory-storage/tests/shared_memory_storage.rs Outdated Show resolved Hide resolved
storages/sled-storage/tests/sled_storage.rs Outdated Show resolved Hide resolved
@ShaddyDC ShaddyDC requested review from ever0de and removed request for panarch and devgony November 16, 2022 13:17
@ever0de ever0de requested a review from panarch November 16, 2022 13:17
@ShaddyDC
Copy link
Contributor Author

Oops, I didn't mean to remove the other review requests by requesting a rereview. Anyway, those should be addressed @ever0de

panarch
panarch approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice! Thanks a lot for the contribution 👍 👍 👍

@panarch panarch merged commit 7804d43 into gluesql:main Nov 16, 2022
@ShaddyDC ShaddyDC deleted the test-suite-tester-async-new branch November 16, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@ShaddyDC ShaddyDC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ShaddyDC @coveralls @panarch @ever0de