Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group the import statements #1005

Merged
merged 15 commits into from
Nov 17, 2022
Merged

Group the import statements #1005

merged 15 commits into from
Nov 17, 2022

Conversation

yugeeklab
Copy link
Contributor

@yugeeklab yugeeklab commented Nov 17, 2022 •
edited by ever0de

Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".

fixed #646

@yugeeklab
Group the import statements in cli
3a74d44 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src/ast
b767f13 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src/ast_builder
3ee4a7a 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src/data/value
984891e 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src/executor
5799efd 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src/plan
9e8df2a 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in core/src
cd61406 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in pkg
2661e95 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in storages
fafdc43 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in test-suite/src/alter
ce11f57 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in test-suite/src/data_type
065bf06 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in test-suite/src/function
a486451 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in test-suite/src/index
13f67b8 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in test-suite/src
dcee2cd 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@yugeeklab
Group the import statements in utils/src
bd66fa3 
Group statements that can group. For example, "use A::b" and
"use A::c" can group into "use A::{b, c}".
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3484630300

  • 23 of 23 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0003%) to 98.428%
Totals Coverage Status
Change from base Build 3480295412: 0.0003%
Covered Lines: 39758
Relevant Lines: 40393
💛 - Coveralls

@yugeeklab yugeeklab changed the title Group the import statements in cli Group the import statements Nov 17, 2022
@devgony devgony requested review from panarch, ever0de, devgony and MRGRAVITY817 and removed request for panarch and ever0de November 17, 2022 02:12
@devgony devgony added the improvement Improvements for existing features label Nov 17, 2022
ever0de
ever0de reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

core/src/executor/alter/mod.rs
test-suite/src/alter/mod.rs
test-suite/src/transaction/mod.rs

The list above doesn't seem to be resolved.

@panarch
Copy link
Member

panarch commented Nov 17, 2022

@ever0de thanks for the review :)
This PR itself doesn't need to cover everything at once so let's merge this into the main and do remainders in a different PR.

panarch
panarch approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome! Thanks a lot for the contribution 👍 Looks all good!

@panarch panarch merged commit 19beceb into gluesql:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de left review comments

@panarch panarch panarch approved these changes

@devgony devgony devgony approved these changes

@MRGRAVITY817 MRGRAVITY817 Awaiting requested review from MRGRAVITY817

Assignees

@yugeeklab yugeeklab

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group the import statements
5 participants
@yugeeklab @coveralls @panarch @ever0de @devgony