Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use rust-cache action to cache dependencies #1006

Merged
merged 1 commit into from
Nov 17, 2022
Merged

chore: Use rust-cache action to cache dependencies #1006

merged 1 commit into from
Nov 17, 2022

Conversation

jongwooo
Copy link
Contributor

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Updated GitHub Action workflows to cache dependencies using Swatinem/rust-cache. Caching dependencies speeds up workflow. For example, Rustfmt execution time was reduced from 2m 12s to 21s.

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@ever0de ever0de added the improvement Improvements for existing features label Nov 17, 2022
@coveralls
Copy link

coveralls commented Nov 17, 2022

Pull Request Test Coverage Report for Build 3489289937

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 98.343%

Files with Coverage Reduction New Missed Lines %
storages/sled-storage/tests/sled_transaction.rs 18 95.81%
test-suite/src/tester/mod.rs 19 87.5%
Totals Coverage Status
Change from base Build 3486015611: -0.09%
Covered Lines: 39873
Relevant Lines: 40545

💛 - Coveralls

Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add options like:

        with:
          shared-key: cargo-test
          cache-on-failure: true

referece: https://github.com/dudykr/stc/blob/d8b849c672f033c1e0a04caf9737f9a6ae7c6863/.github/workflows/CI.yml#L71-L74

Copy link
Contributor Author

@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the following link to check if dependencies are cached.

@ever0de
Copy link
Member

ever0de commented Nov 17, 2022

Could you possibly split them into different keys?

          shared-key: cargo-test
          # or 
          shared-key: cargo-clippy
          # ...

Or does this key not affect other caches?
If so, I'm sorry, can you roll back?

https://github.com/Swatinem/rust-cache

and is stable over multiple jobs.

Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Our waiting time has been reduced.

thanks for the first contribution

@jongwooo
Copy link
Contributor Author

@ever0de I rolled back the code for now. Thank you.

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution 👍
Also thanks to the careful review comments @ever0de

@panarch panarch merged commit 9950ee6 into gluesql:main Nov 17, 2022
@jongwooo jongwooo deleted the chore/use-rust-cache-to-cache-dependencies branch November 17, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants