-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use rust-cache action to cache dependencies #1006
chore: Use rust-cache action to cache dependencies #1006
Conversation
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
Pull Request Test Coverage Report for Build 3489289937
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add options like:
with:
shared-key: cargo-test
cache-on-failure: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the following link to check if dependencies are cached.
Could you possibly split them into different keys? shared-key: cargo-test
# or
shared-key: cargo-clippy
# ... Or does this key not affect other caches? https://github.com/Swatinem/rust-cache
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Our waiting time has been reduced.
thanks for the first contribution
@ever0de I rolled back the code for now. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the contribution 👍
Also thanks to the careful review comments @ever0de
Signed-off-by: jongwooo jongwooo.han@gmail.com
Description
Updated GitHub Action workflows to cache dependencies using Swatinem/rust-cache. Caching dependencies speeds up workflow. For example, Rustfmt execution time was reduced from
2m 12s
to21s
.