Support TableFactor::{Derived, Dictionary, Series} in AstBuilder

[devgony]

Goal

From now, we can use Dictionary, SERIES(N) and Derived subquery even in AstBuilder!

let actual = glue_objects().select().into();
let expected = "SELECT * FROM GLUE_OBJECTS";
test_query(actual, expected);

let actual = glue_tables().select().into();
let expected = "SELECT * FROM GLUE_TABLES";
test_query(actual, expected);

let actual = glue_indexes().select().into();
let expected = "SELECT * FROM GLUE_INDEXES";
test_query(actual, expected);

let actual = glue_table_columns().select().into();
let expected = "SELECT * FROM GLUE_TABLE_COLUMNS";
test_query(actual, expected);

let actual = series("1 + 2").select().into();
let expected = "SELECT * FROM SERIES(1 + 2)";
test_query(actual, expected);

let actual = table("Items").select().alias_as("Sub").select().into();
let expected = "SELECT * FROM (SELECT * FROM Items) AS Sub";
test_query(actual, expected);

Todo

• implement Dictionary, Series with TableType
• implement Derived with Box<SelectNode>

Next

• impl values for ast_builder
• impl alias_as for ValuesNode

[coveralls]

Pull Request Test Coverage Report for Build 3592779396

• 623 of 639 (97.5%) changed or added relevant lines in 17 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.02%) to 98.53%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
test-suite/src/ast_builder/alias_as.rs	232	248	93.55%

Files with Coverage Reduction	New Missed Lines	%
test-suite/src/tester/mod.rs	1	87.5%

Totals
Change from base Build 3592201016:	-0.02%
Covered Lines:	37460
Relevant Lines:	38019

---

💛 - Coveralls

[ever0de]

Suggested change

	pub fn alias_as(self, table_alias: &'a str) -> TableAliasNode {
	pub fn alias_as(self, table_alias: &str) -> TableAliasNode<'a> {

I think it is correct to declare this lifetime in TableAliasNode, not in str.

[ever0de]

It seems that there is unreachable code inside the translate_table_args closure, because the value of None for args will never go into translate_table_args.

[panarch]

1. nit. except for series which takes Into<ExprNode<'a>>, all has static lifetimes.

e.g.

pub fn glue_table_columns() -> TableNode<'static> { .. }

this would be enough.

---

2. Now table sugar functions are more than a single one, then how about moving these including series into table.rs module?

[panarch]

This is too cool feature! Could we have an usage example in test-suite/ ast_builder/select.rs?

[panarch]

Awesome 👍 👍 👍
Now we can chain select queries as many as we want.
All looks great! Thanks a lot 👍