Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value/ binary_op Parital{Ord,Cmp} impl macro #1013

Merged
merged 2 commits into from
Nov 19, 2022
Merged

Add value/ binary_op Parital{Ord,Cmp} impl macro #1013

merged 2 commits into from
Nov 19, 2022

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Nov 19, 2022

No description provided.

@ever0de ever0de added the improvement Improvements for existing features label Nov 19, 2022
@ever0de ever0de self-assigned this Nov 19, 2022
@coveralls
Copy link

coveralls commented Nov 19, 2022 •
edited

Pull Request Test Coverage Report for Build 3502862923

  • 84 of 84 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.704%
Totals Coverage Status
Change from base Build 3502442130: 0.2%
Covered Lines: 36333
Relevant Lines: 36810
💛 - Coveralls

panarch
panarch approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks a lot 👍

@panarch panarch changed the title Add macro implement Parital{Ord,Cmp} Add value/ binary_op Parital{Ord,Cmp} impl macro Nov 19, 2022
@panarch panarch merged commit 24ec33b into gluesql:main Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@ever0de ever0de

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ever0de @coveralls @panarch