Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add null() func which makes NULL value in AST builder #1016

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Add null() func which makes NULL value in AST builder #1016

merged 1 commit into from
Nov 22, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Nov 22, 2022

cc. @ShaddyDC

@panarch panarch self-assigned this Nov 22, 2022
@panarch panarch added the improvement Improvements for existing features label Nov 22, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3521163774

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 53 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 98.543%
Files with Coverage Reduction New Missed Lines %
test-suite/src/tester/mod.rs 19 87.5%
core/src/executor/aggregate/mod.rs 34 81.82%
Totals Coverage Status
Change from base Build 3503237510: -0.1%
Covered Lines: 36929
Relevant Lines: 37475
💛 - Coveralls

ever0de
ever0de approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks to @ShaddyDC

@panarch panarch merged commit 8cb80a8 into main Nov 22, 2022
@panarch panarch deleted the null-exprnode-function-to-ast-builder branch November 22, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony devgony approved these changes

Assignees

@panarch panarch

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@panarch @coveralls @ever0de @devgony