Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NumericNode to handle numeric value inputs in AST builder #1017

Merged

Conversation

panarch
Copy link
Member

@panarch panarch commented Nov 23, 2022

Now, num AST builder sugar function supports multiple different types including i64, f64, and &str.

e.g.

num("1.23");
num(100_i64);
num(300_i32);
num(1.234);

cc. @ShaddyDC

@panarch panarch added the improvement Improvements for existing features label Nov 23, 2022
@panarch panarch self-assigned this Nov 23, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3530418075

  • 76 of 77 (98.7%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 98.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test-suite/src/ast_builder/basic.rs 6 7 85.71%
Files with Coverage Reduction New Missed Lines %
core/src/executor/validate.rs 1 99.32%
Totals Coverage Status
Change from base Build 3521729689: 0.006%
Covered Lines: 37004
Relevant Lines: 37550

💛 - Coveralls

@panarch panarch merged commit a3e3721 into main Nov 24, 2022
@panarch panarch deleted the ast-builder-num-func-to-accept-both-int-and-float-values branch November 24, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants