Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LIST type support in CONCAT function #1021

Merged
merged 8 commits into from
Nov 26, 2022
Merged

Add LIST type support in CONCAT function #1021

merged 8 commits into from
Nov 26, 2022

Conversation

seonghun-dev
Copy link
Contributor

Resolve : #890

@seonghun-dev seonghun-dev marked this pull request as ready for review November 26, 2022 08:49
@coveralls
Copy link

coveralls commented Nov 26, 2022 •
edited

Pull Request Test Coverage Report for Build 3553763206

  • 59 of 60 (98.33%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 98.574%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/executor/evaluate/function.rs 7 8 87.5%
Totals Coverage Status
Change from base Build 3552832374: 0.03%
Covered Lines: 36497
Relevant Lines: 37025
💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Nov 26, 2022
@panarch panarch requested a review from ever0de November 26, 2022 11:59
@panarch panarch self-requested a review November 26, 2022 12:03
@panarch panarch requested a review from ever0de November 26, 2022 12:58
ever0de
ever0de approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panarch panarch changed the title [AST] Add LIST DataType to Concat Function Add LIST type support in CONCAT function Nov 26, 2022
panarch
panarch approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!
All looks nice! Thanks a lot for the contribution 👍
Also thanks @ever0de for the careful review

@panarch panarch merged commit 075a3c4 into gluesql:main Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

Assignees

@seonghun-dev seonghun-dev

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AST] Add LIST DataType to Concat Function
4 participants
@seonghun-dev @coveralls @panarch @ever0de