Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge insert logics in row.rs & execute.rs into executor/insert.rs #1031

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Dec 1, 2022

…module

prior pr #1029

Insert execution code logics are splitted in data/row.rs and executor/execute.rs
By adding executor/insert.rs, it merges the codes into a single insert module.

@panarch panarch added the improvement Improvements for existing features label Dec 1, 2022
@panarch panarch self-assigned this Dec 1, 2022
@coveralls
Copy link

coveralls commented Dec 1, 2022

Pull Request Test Coverage Report for Build 3590936141

  • 157 of 162 (96.91%) changed or added relevant lines in 4 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 98.594%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/executor/execute.rs 2 3 66.67%
core/src/executor/insert.rs 149 153 97.39%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 7 82.2%
Totals Coverage Status
Change from base Build 3590702792: 0.02%
Covered Lines: 36804
Relevant Lines: 37329

💛 - Coveralls

Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panarch panarch merged commit 34c628c into main Dec 1, 2022
@panarch panarch deleted the refactor-insert-codes branch December 1, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants