Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename executor/ blend.rs module to project.rs #1036

Merged
merged 3 commits into from
Dec 2, 2022

Conversation

SaumyaBhushan
Copy link
Contributor

@SaumyaBhushan SaumyaBhushan commented Dec 1, 2022

workerB

fixed #1034

@ever0de
Copy link
Member

ever0de commented Dec 2, 2022

Check CI. Rust module names have not changed.

@panarch
Copy link
Member

panarch commented Dec 2, 2022

Welcome 👍
It would be good to also find & replace blend text uses in source codes to project.

@coveralls
Copy link

coveralls commented Dec 2, 2022

Pull Request Test Coverage Report for Build 3598966579

  • 55 of 55 (100.0%) changed or added relevant lines in 8 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 98.587%

Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 2 82.72%
Totals Coverage Status
Change from base Build 3593562496: 0.04%
Covered Lines: 37323
Relevant Lines: 37858

💛 - Coveralls

@panarch
Copy link
Member

panarch commented Dec 2, 2022

Everything looks nice!
To pass the gh actions, the only remaining one to run is cargo fmt --all in the root directory.
Then, all the gh actions will pass.

@SaumyaBhushan
Copy link
Contributor Author

@panarch Its done . Thanks alot for the help .

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution 👍 👍 👍

@panarch panarch merged commit 2f62e33 into gluesql:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename executor/ blend.rs module to project.rs
4 participants