Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder project in ASTBuilder (project -> ordery_by -> limit,offset) #1039

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Dec 6, 2022

Goal

Currently, the execution order of ASTBuilder is different with Core
Let's sync the order to project -> ordery_by -> limit,offset

Before

order_by -> limit,offset -> project

After

project -> order_by -> limit,offset

Todo

  • Add order_by, limit, offset to ProjectNode
  • Remove project from OrderByNode, LimitNode, OffsetNode, OffsetLimitNode

@devgony devgony marked this pull request as ready for review December 6, 2022 07:18
@devgony devgony self-assigned this Dec 6, 2022
@devgony devgony added the improvement Improvements for existing features label Dec 6, 2022
@coveralls
Copy link

coveralls commented Dec 6, 2022

Pull Request Test Coverage Report for Build 3627372971

  • 30 of 30 (100.0%) changed or added relevant lines in 8 files are covered.
  • 40 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.08%) to 98.534%

Files with Coverage Reduction New Missed Lines %
core/src/data/value/json.rs 1 99.53%
test-suite/src/ast_builder/select.rs 1 93.2%
core/src/ast_builder/select/project.rs 12 95.08%
core/src/executor/aggregate/mod.rs 26 86.39%
Totals Coverage Status
Change from base Build 3627102110: -0.08%
Covered Lines: 37307
Relevant Lines: 37862

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice. Thanks a lot 👍

@panarch panarch merged commit c3a33c5 into gluesql:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants