Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ast::ColumnOption::Default variant to ColumnDef #1042

Merged
merged 3 commits into from
Dec 10, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Dec 9, 2022

Each ColumnDef can have at most one ColumnOption::Default but current ast structure allows ColumnDef to have multiple Defaults.
Resolve this by adding default field to ColumnDef and remove ColumnOption::Default.


It can also be applied to ColumnOption::Unique which is the last enum variant of ColumnOption.

@panarch panarch added the improvement Improvements for existing features label Dec 9, 2022
@panarch panarch self-assigned this Dec 9, 2022
@coveralls
Copy link

coveralls commented Dec 9, 2022

Pull Request Test Coverage Report for Build 3662653145

  • 67 of 67 (100.0%) changed or added relevant lines in 11 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.003%) to 98.559%

Files with Coverage Reduction New Missed Lines %
core/src/executor/evaluate/mod.rs 7 97.48%
core/src/result.rs 7 69.77%
Totals Coverage Status
Change from base Build 3630622723: 0.003%
Covered Lines: 37336
Relevant Lines: 37882

💛 - Coveralls

core/src/translate/ddl.rs Outdated Show resolved Hide resolved
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panarch panarch merged commit 8b5a440 into main Dec 10, 2022
@panarch panarch deleted the move-default-from-columoption-to-columndef branch December 10, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants