Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite & simplify plan/context.rs codes, #1045

Merged
merged 1 commit into from
Dec 11, 2022
Merged

Rewrite & simplify plan/context.rs codes, #1045

merged 1 commit into from
Dec 11, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Dec 11, 2022

Convert Context struct to enum and make all states reachable by codes in the plan module

@panarch
Rewrite & simplify plan/context.rs codes,
33cbff5 
Convert Context struct to enum and make all states reachable by codes in the plan module
@panarch panarch added the improvement Improvements for existing features label Dec 11, 2022
@panarch panarch self-assigned this Dec 11, 2022
@coveralls
Copy link

coveralls commented Dec 11, 2022 •
edited

Pull Request Test Coverage Report for Build 3669648160

  • 60 of 63 (95.24%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 98.607%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/plan/context.rs 43 46 93.48%
Totals Coverage Status
Change from base Build 3662721935: 0.02%
Covered Lines: 37312
Relevant Lines: 37839
💛 - Coveralls

@panarch panarch merged commit 3043b0d into main Dec 11, 2022
@panarch panarch deleted the plan-context-refactoring branch December 11, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devgony devgony devgony approved these changes

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@panarch panarch

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @devgony