Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AST] Add Append Function to LIST DataType #1047

Merged
merged 10 commits into from
Mar 22, 2023
Merged

[AST] Add Append Function to LIST DataType #1047

merged 10 commits into from
Mar 22, 2023

Conversation

seonghun-dev
Copy link
Contributor

Resolve: #1024

@ever0de ever0de added the enhancement New feature or request label Dec 17, 2022
@coveralls
Copy link

coveralls commented Dec 17, 2022 •
edited

Pull Request Test Coverage Report for Build 4467766497

  • 98 of 98 (100.0%) changed or added relevant lines in 8 files are covered.
  • 33 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 98.758%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 33 82.9%
Totals Coverage Status
Change from base Build 4454605218: -0.07%
Covered Lines: 40148
Relevant Lines: 40653
💛 - Coveralls

@panarch panarch self-requested a review March 18, 2023 11:58
panarch
panarch approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks all nice 👍
Thanks a lot!

@panarch panarch merged commit 751c288 into gluesql:main Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@seonghun-dev seonghun-dev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AST] Add Append Function to LIST DataType
4 participants
@seonghun-dev @coveralls @panarch @ever0de