Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WebStorage - support localStorage & sessionStorage for web browsers #1050

Merged
merged 4 commits into from
Dec 26, 2022
Merged

Add WebStorage - support localStorage & sessionStorage for web browsers #1050

merged 4 commits into from
Dec 26, 2022

Conversation

panarch
Copy link
Member

@panarch panarch commented Dec 26, 2022

WebStorage includes two storages

  • localStorage
  • sessionStorage

This PR only verifies the storage implementation.
It does not have gluesql javascript interface integration that will be done separately.

@panarch panarch added the enhancement New feature or request label Dec 26, 2022
@panarch panarch self-assigned this Dec 26, 2022
@coveralls
Copy link

coveralls commented Dec 26, 2022 •
edited

Pull Request Test Coverage Report for Build 3781802067

  • 3 of 3 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0001%) to 98.516%
Totals Coverage Status
Change from base Build 3775547151: 0.0001%
Covered Lines: 37771
Relevant Lines: 38340
💛 - Coveralls

@panarch panarch mentioned this pull request Dec 26, 2022
Open
ever0de
ever0de approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good except for improvement comments
The interface looks pretty simple 👍

storages/web-storage/src/lib.rs Outdated Show resolved Hide resolved
@panarch panarch merged commit 8966872 into main Dec 26, 2022
@panarch panarch deleted the local-and-session-storages branch December 26, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @ever0de