Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IndexedDB storage support #1067

Merged
merged 21 commits into from
Jan 21, 2023
Merged

Add IndexedDB storage support #1067

merged 21 commits into from
Jan 21, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Jan 18, 2023 •
edited

Initial IndexedDB storage support for GlueSQL.
It uses https://github.com/devashishdxt/idb
Thanks @devashishdxt

@panarch panarch added the enhancement New feature or request label Jan 18, 2023
@panarch panarch self-assigned this Jan 18, 2023
@coveralls
Copy link

coveralls commented Jan 18, 2023 •
edited

Pull Request Test Coverage Report for Build 3974773700

  • 93 of 93 (100.0%) changed or added relevant lines in 6 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.0009%) to 98.519%
Files with Coverage Reduction New Missed Lines %
core/src/data/value/convert.rs 1 98.77%
Totals Coverage Status
Change from base Build 3935663212: 0.0009%
Covered Lines: 37850
Relevant Lines: 38419
💛 - Coveralls

@panarch panarch marked this pull request as ready for review January 21, 2023 07:39
ever0de
ever0de reviewed Jan 21, 2023
View reviewed changes
storages/idb-storage/src/convert.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/convert.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/lib.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/lib.rs Show resolved Hide resolved
storages/idb-storage/src/lib.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/lib.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/lib.rs Outdated Show resolved Hide resolved
storages/idb-storage/src/lib.rs Outdated Show resolved Hide resolved
ever0de
ever0de approved these changes Jan 21, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Took a look at IndexedDB's interesting interface. It's interesting.

@panarch panarch merged commit dc8d53d into main Jan 21, 2023
@panarch panarch deleted the indexeddb-storage branch January 21, 2023 12:50
This was referenced Jan 21, 2023
Closed
Closed
@panarch panarch mentioned this pull request Apr 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @ever0de