Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompositeStorage which bundles multiple storages #1068

Merged
merged 11 commits into from
Feb 5, 2023
Merged

Conversation

panarch
Copy link
Member

@panarch panarch commented Jan 23, 2023

e.g.

CREATE TABLE Foo ( .. ) ENGINE = MEMORY;
CREATE TABLE Bar ( .. ) ENGINE = SLED;

..

SELECT * FROM Foo JOIN Bar;

@panarch panarch added the enhancement New feature or request label Jan 23, 2023
@panarch panarch self-assigned this Jan 23, 2023
@coveralls
Copy link

coveralls commented Jan 23, 2023

Pull Request Test Coverage Report for Build 4095590144

  • 444 of 458 (96.94%) changed or added relevant lines in 18 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 98.558%

Changes Missing Coverage Covered Lines Changed/Added Lines %
storages/composite-storage/src/lib.rs 49 52 94.23%
storages/composite-storage/src/store.rs 28 32 87.5%
storages/composite-storage/src/store_mut.rs 38 45 84.44%
Totals Coverage Status
Change from base Build 4040662072: -0.002%
Covered Lines: 38415
Relevant Lines: 38977

💛 - Coveralls

@panarch panarch changed the title Add CompositeStorage which bundles multiple storages into a single storage Add CompositeStorage which bundles multiple storages Jan 23, 2023
@panarch panarch marked this pull request as ready for review February 3, 2023 09:10
storages/composite-storage/Cargo.toml Outdated Show resolved Hide resolved
storages/composite-storage/src/lib.rs Outdated Show resolved Hide resolved
storages/composite-storage/src/store.rs Show resolved Hide resolved
@panarch panarch requested a review from ever0de February 5, 2023 07:48
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@panarch panarch merged commit 03b21af into main Feb 5, 2023
@panarch panarch deleted the composite-storage branch February 5, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants