Update all store mut trait methods to take &mut self #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change StoreMut methods to return &mut Self
Pull Request Test Coverage Report for Build 4035481981
💛 - Coveralls |
Update AlterTable, IndexMut and Transaction trait methods to take &mut Self and return Result<..>
panarch
changed the title
Merged
ever0de
approved these changes
Jan 29, 2023
core/src/executor/alter/table.rs
Outdated
| Continue(column_types) => column_types, | ||
| Break(column_types) => column_types?, | ||
| ) -> Result<()> { | ||
| let target_columns_defs = match source.as_ref().map(AsRef::as_ref) { |
There was a problem hiding this comment.
Suggested change
| let target_columns_defs = match source.as_ref().map(AsRef::as_ref) { | |
| let target_columns_defs = match source.as_deref() { |
| } | ||
| } | ||
| } | ||
|
|
||
| async fn fetch_vec_rows<T: GStore + GStoreMut>( | ||
| async fn fetch_vec_rows<T: GStore>( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove IStoreMut, core only uses StoreMut with &mut self.
Update AlterTable, IndexMut and Transaction trait methods to take &mut self.