Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CreateTable.columns from Vec<ColumnDef> to Option<Vec<ColumnDef>> #1086

Merged
merged 3 commits into from
Feb 9, 2023

Conversation

devgony
Copy link
Collaborator

@devgony devgony commented Feb 9, 2023

Goal

# core/src/ast/mod.rs
CreateTable {                                                                                     
    if_not_exists: bool,                                                                          
    name: String,                                                                                 
    Optional schema                                                                           
-  columns: Vec<ColumnDef>,
+  columns: Option<Vec<ColumnDef>>,
    source: Option<Box<Query>>,                                                                   
    engine: Option<String>,                                                                       
},                          

Todo

Refactor CreateTable.columns from Vec<ColumnDef> to Option<Vec<ColumnDef>>

Next

  • implement from_ddl()

@coveralls
Copy link

coveralls commented Feb 9, 2023

Pull Request Test Coverage Report for Build 4133443138

  • 61 of 62 (98.39%) changed or added relevant lines in 6 files are covered.
  • 48 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 98.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/executor/execute.rs 9 10 90.0%
Files with Coverage Reduction New Missed Lines %
core/src/executor/evaluate/stateless.rs 15 94.09%
core/src/executor/aggregate/mod.rs 33 83.33%
Totals Coverage Status
Change from base Build 4110793318: -0.06%
Covered Lines: 39438
Relevant Lines: 40019

💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Feb 9, 2023
@devgony devgony changed the title Refactor CreateTable.columns to Option<Vec<_>> Refactor CreateTable.columns from Vec<ColumnDef> to Option<Vec<ColumnDef>> Feb 9, 2023
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good catch! All looks good :D

@panarch panarch merged commit 554c0fb into gluesql:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants