Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cargo.toml files to inherit workspace level configs, #1088

Merged
merged 4 commits into from
Feb 10, 2023
Merged

Update Cargo.toml files to inherit workspace level configs, #1088

merged 4 commits into from
Feb 10, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Feb 9, 2023 •
edited

Shares edition, description, license, repository and documentation fields

ref. rustwasm/wasm-pack#1185
so exclude wasm-pack related workspaces

@panarch
Update Cargo.toml files to inherit workspace level configs,
cb53aef 
Shares edition, description, license, repository and documentation fields
@panarch panarch self-assigned this Feb 9, 2023
@coveralls
Copy link

coveralls commented Feb 9, 2023 •
edited

Pull Request Test Coverage Report for Build 4133905480

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.624%
Totals Coverage Status
Change from base Build 4133523165: 0.0%
Covered Lines: 39273
Relevant Lines: 39821
💛 - Coveralls

ever0de
ever0de approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@panarch panarch merged commit 1277a7e into main Feb 10, 2023
@panarch panarch deleted the apply-workspace-inheritance-config branch February 10, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @ever0de