Remove Store trait related cfg features, #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable all by default.
Pull Request Test Coverage Report for Build 4144994883
💛 - Coveralls |
ever0de
approved these changes
Feb 10, 2023
v0.14 release will be .. next month so it would be too early to update README at this moment. |
devgony
pushed a commit
to devgony/gluesql
that referenced
this pull request
Mar 6, 2023
Enable all by default. Compile time feature control causes too much management cost. We already have test cases in test-suite splitted based on store trait features.
devgony
added a commit
to devgony/gluesql
that referenced
this pull request
Mar 6, 2023
Remove Store trait related cfg features, (gluesql#1091) Enable all by default. Compile time feature control causes too much management cost. We already have test cases in test-suite splitted based on store trait features. Support `values` query in AST builder (gluesql#1041) Currently, ASTBuilder does not support Values Query yet. This PR supports Values Query in ASTBuilder e.g. let actual = values(vec!["1, 'a'", "2, 'b'"]) .order_by(vec!["column1 desc"]) .build(); let expected = "VALUES(1, 'a'), (2, 'b') ORDER BY column1 desc";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable all by default.
Compile time feature control causes too much management cost.
We already have test cases in
test-suitesplitted based on store trait features.