Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core/data module unit tests #1092

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Add core/data module unit tests #1092

merged 2 commits into from
Feb 13, 2023

Conversation

pythonbrad
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4155788299

  • 33 of 33 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 98.699%
Totals Coverage Status
Change from base Build 4151127338: 0.09%
Covered Lines: 38381
Relevant Lines: 38887
💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Feb 12, 2023
@panarch panarch self-requested a review February 12, 2023 10:56
@panarch
Copy link
Member

panarch commented Feb 12, 2023

Thanks! Looks all nice to be merged.
You set this PR as draft. do you have plan to do some more changes to this pr?

@pythonbrad pythonbrad marked this pull request as ready for review February 13, 2023 11:28
@pythonbrad
Copy link
Contributor Author

Thanks! Looks all nice to be merged. You set this PR as draft. do you have plan to do some more changes to this pr?

I projected to add more, but i don't think that i will have the time.

It can be merged.

@panarch panarch changed the title Add tests Add core/data module unit tests Feb 13, 2023
panarch
panarch approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍
Looks all nice!

@panarch panarch merged commit 484dbb2 into gluesql:main Feb 13, 2023
@pythonbrad pythonbrad deleted the test branch February 13, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

Assignees

@pythonbrad pythonbrad

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pythonbrad @coveralls @panarch