Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cli" unittest #1094

Merged
merged 5 commits into from
Feb 14, 2023
Merged

Add "cli" unittest #1094

merged 5 commits into from
Feb 14, 2023

Conversation

pythonbrad
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 13, 2023

Pull Request Test Coverage Report for Build 4168962125

  • 128 of 128 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 98.801%

Totals Coverage Status
Change from base Build 4163785285: 0.1%
Covered Lines: 39721
Relevant Lines: 40203

💛 - Coveralls

@pythonbrad
Copy link
Contributor Author

pythonbrad commented Feb 13, 2023

[Select { labels: ["name"], rows: [] }]
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', pkg/rust/examples/sled_multi_threaded.rs:59:26

This error can be manage if we wait for the thread to terminate before get the row.

@panarch panarch added the improvement Improvements for existing features label Feb 14, 2023
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 👍 👍

@panarch panarch merged commit 8684f16 into gluesql:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants