Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement FIND_IDX function #1100

Merged
merged 8 commits into from
Mar 5, 2023
Merged

Implement FIND_IDX function #1100

merged 8 commits into from
Mar 5, 2023

Conversation

zmrdltl
Copy link
Collaborator

@zmrdltl zmrdltl commented Feb 18, 2023 •
edited

Background

Tasks

  • ast
  • ast_builder
  • tests

@zmrdltl
Implement FIND_IDX function
80f39bd 
- add mysql function locate
- in ast_builder, Using the locate(substring, fromstring, start) expression is not intuitive for function names.
Therefore, the name was changed to find_idx and implemented.
- https://dev.mysql.com/doc/refman/8.0/en/string-functions.html#function_locate

Signed-off-by: MeenSeek Kim <meenseek5929@naver.com>
@coveralls
Copy link

coveralls commented Feb 18, 2023 •
edited

Pull Request Test Coverage Report for Build 4324548604

  • 190 of 190 (100.0%) changed or added relevant lines in 10 files are covered.
  • 30 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.04%) to 98.727%
Files with Coverage Reduction New Missed Lines %
core/src/ast/mod.rs 1 99.8%
core/src/plan/schema.rs 3 99.09%
core/src/executor/aggregate/mod.rs 7 82.99%
test-suite/src/tester/mod.rs 19 87.33%
Totals Coverage Status
Change from base Build 4302696788: -0.04%
Covered Lines: 40649
Relevant Lines: 41173
💛 - Coveralls

@zmrdltl
feat: add ast_builder for function find_idx
da3bee5 
Signed-off-by: MeenSeek Kim <meenseek5929@naver.com>
@zmrdltl
test: add to_sql
568df77
@panarch panarch added the enhancement New feature or request label Mar 3, 2023
@zmrdltl
refactor: parameter sequnce
abc666c 
Signed-off-by: MeenSeek Kim <meenseek5929@naver.com>
@zmrdltl
refactor: shrink code of using crate Value
7390961 
Signed-off-by: MeenSeek Kim <meenseek5929@naver.com>
@zmrdltl
Merge remote-tracking branch 'upstream/main' into feature-function_fi…
4b08b95 
…ndidx
panarch
panarch approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all great!
Thanks a lot 👍

@panarch panarch merged commit ddba983 into gluesql:main Mar 5, 2023
@zmrdltl zmrdltl deleted the feature-function_findidx branch March 5, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@devgony devgony Awaiting requested review from devgony

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@zmrdltl zmrdltl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zmrdltl @coveralls @panarch