Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split JS related GitHub action, #1109

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Split JS related GitHub action, #1109

merged 2 commits into from
Mar 1, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Mar 1, 2023

Add workflows/javascript.yml
Split JS workflow into build & storage tests

@panarch
Split JS related GitHub action,
19ea155 
Add workflows/javascript.yml
Split JS workflow into build & storage tests
@panarch panarch requested review from ever0de and devgony March 1, 2023 05:04
@panarch panarch self-assigned this Mar 1, 2023
@panarch
Rename javascript.yml gh action job names,
04a97bc 
Remove - JavaScript postfix
@coveralls
Copy link

coveralls commented Mar 1, 2023 •
edited

Pull Request Test Coverage Report for Build 4300291823

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 98.757%
Files with Coverage Reduction New Missed Lines %
core/src/executor/aggregate/mod.rs 7 82.99%
Totals Coverage Status
Change from base Build 4287849607: -0.02%
Covered Lines: 39871
Relevant Lines: 40373
💛 - Coveralls

ever0de
ever0de approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panarch panarch merged commit 17afd4a into main Mar 1, 2023
@panarch panarch deleted the split-javascript-action branch March 1, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @ever0de