Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ord impl for Key, #1110

Merged
merged 4 commits into from
Mar 5, 2023
Merged

Add Ord impl for Key, #1110

merged 4 commits into from
Mar 5, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Mar 1, 2023

Implement Ord for Key.
Update JsonlStorage to use this for sorting

@panarch
Add Ord impl for Key,
0afe0e6 
Implement Ord for Key.
Update JsonlStorage to use this for sorting
@panarch panarch added the improvement Improvements for existing features label Mar 1, 2023
@panarch panarch self-assigned this Mar 1, 2023
@panarch panarch requested review from devgony and ever0de March 1, 2023 08:16
@panarch panarch marked this pull request as ready for review March 1, 2023 08:16
@coveralls
Copy link

coveralls commented Mar 1, 2023 •
edited

Pull Request Test Coverage Report for Build 4301517900

  • 111 of 111 (100.0%) changed or added relevant lines in 4 files are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 98.768%
Files with Coverage Reduction New Missed Lines %
core/src/executor/execute.rs 19 92.02%
Totals Coverage Status
Change from base Build 4300525566: -0.03%
Covered Lines: 39918
Relevant Lines: 40416
💛 - Coveralls

@panarch panarch mentioned this pull request Mar 3, 2023
Merged
ever0de
ever0de approved these changes Mar 4, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@panarch panarch merged commit ad8e7ef into main Mar 5, 2023
@panarch panarch deleted the add-ord-impl-to-key branch March 5, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony Awaiting requested review from devgony

Assignees

@panarch panarch

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@panarch @coveralls @ever0de