Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join_expr when in_subquery, exists expr in join constraint #1112

Merged
merged 2 commits into from
Mar 1, 2023
Merged

join_expr when in_subquery, exists expr in join constraint #1112

merged 2 commits into from
Mar 1, 2023

Conversation

ding-young
Copy link
Contributor

Description

  • find hash join expr in in_subquery, exists in join constraint
  • add test case for subquery, in_subquery, exist branch

@coveralls
Copy link

coveralls commented Mar 1, 2023 •
edited

Pull Request Test Coverage Report for Build 4301896801

  • 83 of 86 (96.51%) changed or added relevant lines in 1 file are covered.
  • 19 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 98.828%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/plan/join.rs 83 86 96.51%
Files with Coverage Reduction New Missed Lines %
core/src/executor/execute.rs 19 92.02%
Totals Coverage Status
Change from base Build 4300525566: 0.03%
Covered Lines: 39793
Relevant Lines: 40265
💛 - Coveralls

@panarch panarch added the improvement Improvements for existing features label Mar 1, 2023
@panarch panarch requested review from ever0de and panarch March 1, 2023 10:30
panarch
panarch approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all great!
Also thanks for adding well organized test cases.
Thanks a lot 👍

@panarch panarch merged commit 0196e69 into gluesql:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de Awaiting requested review from ever0de

Assignees

@ding-young ding-young

Labels
improvement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ding-young @coveralls @panarch