Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemoryStorage & WebStorage primary key support #1115

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Mar 3, 2023

depends on #1114

Fix MemoryStorage primary key support - replace IndexMap to BTreeMap for storing rows.
Fix WebStorage primary key support - sort on scan_data if primary key exists in the schema.
Update test-suite/ primary_key to test edge cases.

@panarch panarch added the bug Something isn't working label Mar 3, 2023
@panarch panarch requested review from ever0de and devgony March 3, 2023 11:25
@panarch panarch self-assigned this Mar 3, 2023
@coveralls
Copy link

coveralls commented Mar 3, 2023

Pull Request Test Coverage Report for Build 4335920034

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • 46 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 98.734%

Files with Coverage Reduction New Missed Lines %
core/src/executor/validate.rs 1 99.24%
test-suite/src/tester/mod.rs 19 87.33%
core/src/executor/aggregate/mod.rs 26 86.6%
Totals Coverage Status
Change from base Build 4335910391: -0.1%
Covered Lines: 40322
Relevant Lines: 40839

💛 - Coveralls

@panarch panarch changed the title Fix MemoryStorage to support primary key properly, Fix MemoryStorage & WebStorage primary key support Mar 3, 2023
Fix MemoryStorage primary key support - replace IndexMap to BTreeMap for storing rows.
Fix WebStorage primary key support - sort on scan_data if primary key exists in the schema.
Update test-suite/ primary_key to test edge cases.
@panarch panarch force-pushed the fix-memorystorage-primarykey-support branch from e8f157f to f7e7e20 Compare March 5, 2023 12:03
@panarch panarch requested review from ever0de and removed request for ever0de March 5, 2023 12:03
@panarch panarch merged commit e32984c into main Mar 5, 2023
@panarch panarch deleted the fix-memorystorage-primarykey-support branch March 5, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants