Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass data even when deleted_by is not present #1117

Merged

Conversation

ever0de
Copy link
Member

@ever0de ever0de commented Mar 11, 2023

sled storage bug(reported by @devgony, fixed by @panarch)

Before

gluesql> create table foo(id int primary key);
Table created

gluesql> insert into foo values(1),(2);
2 rows inserted

gluesql> delete from foo where id =1 ;
1 row deleted

gluesql> insert into foo values(1);
data: SnapshotItem { data: Vec([I64(1)]), created_by: 3, deleted_by: Some(4) }
1 row inserted

gluesql> select * from foo;
| id |
|----|
| 2  |

gluesql> insert into foo values(1);
data: SnapshotItem { data: Vec([I64(1)]), created_by: 3, deleted_by: Some(4) }
1 row inserted

gluesql> select * from foo;
| id |
|----|
| 2  |

Co-authored-by: devgony <51254761+devgony@users.noreply.github.com>
Co-authored-by: Taehoon Moon <taehoon.moon@outlook.com>
@ever0de ever0de added the bug Something isn't working label Mar 11, 2023
@ever0de ever0de requested a review from panarch March 11, 2023 07:15
@ever0de ever0de self-assigned this Mar 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4391189274

  • 48 of 48 (100.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 98.813%

Files with Coverage Reduction New Missed Lines %
core/src/executor/insert.rs 6 96.74%
Totals Coverage Status
Change from base Build 4336544732: 0.07%
Covered Lines: 39545
Relevant Lines: 40020

💛 - Coveralls

Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix! Thanks a lot 👍 👍 👍

@panarch panarch merged commit e7d28e7 into gluesql:main Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants