Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix column alias with identifer for TableFactor::Derived #1119

Merged
merged 2 commits into from
Mar 11, 2023

Conversation

ding-young
Copy link
Contributor

Issue

fix #1060

@coveralls
Copy link

coveralls commented Mar 11, 2023

Pull Request Test Coverage Report for Build 4391517722

  • 30 of 32 (93.75%) changed or added relevant lines in 2 files are covered.
  • 27 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 98.785%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/executor/fetch.rs 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
core/src/ast/mod.rs 1 99.8%
core/src/executor/aggregate/mod.rs 26 86.6%
Totals Coverage Status
Change from base Build 4391237963: -0.05%
Covered Lines: 40585
Relevant Lines: 41084

💛 - Coveralls

@panarch panarch added the bug Something isn't working label Mar 11, 2023
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks the best one we can choose for now. looks all good! Thanks a lot 👍

@panarch panarch merged commit 4908b85 into gluesql:main Mar 11, 2023
@panarch panarch changed the title fix column alias with identifer Fix column alias with identifer for TableFactor::Derived Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column alias should be supported in identifier
3 participants