Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(readme): add discord icon to chat badge #1122

Merged
merged 2 commits into from
Mar 12, 2023
Merged

docs(readme): add discord icon to chat badge #1122

merged 2 commits into from
Mar 12, 2023

Conversation

LeoDog896
Copy link
Contributor

Suggested by #1069.

@coveralls
Copy link

coveralls commented Mar 11, 2023 •
edited

Pull Request Test Coverage Report for Build 4397510859

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.832%
Totals Coverage Status
Change from base Build 4392222049: 0.05%
Covered Lines: 40094
Relevant Lines: 40568
💛 - Coveralls

@panarch panarch requested review from panarch and ever0de March 12, 2023 06:18
@panarch panarch added the documentation Improvements or additions to documentation label Mar 12, 2023
@panarch
Copy link
Member

panarch commented Mar 12, 2023

I like this change. Thanks :)
Before merging this, could we use white color for discord logo rather than blue one?
image

ever0de
ever0de approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@ever0de ever0de left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
image

panarch
panarch approved these changes Mar 12, 2023
View reviewed changes
Copy link
Member

@panarch panarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks a lot 👍

@panarch panarch merged commit 64e4938 into gluesql:main Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panarch panarch panarch approved these changes

@ever0de ever0de ever0de approved these changes

Assignees

@LeoDog896 LeoDog896

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeoDog896 @coveralls @panarch @ever0de