Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify JsonlStorage codes #1126

Merged
merged 2 commits into from
Mar 25, 2023
Merged

Simplify JsonlStorage codes #1126

merged 2 commits into from
Mar 25, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Mar 25, 2023 •
edited

  1. Simplify SortMerge::next codes
  2. Simplify Store::fetch_data impl by replacing from find_map to for loop

@panarch panarch requested review from ever0de and devgony March 25, 2023 05:08
@panarch panarch self-assigned this Mar 25, 2023
@coveralls
Copy link

coveralls commented Mar 25, 2023 •
edited

Pull Request Test Coverage Report for Build 4517690753

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • 53 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.09%) to 98.776%
Files with Coverage Reduction New Missed Lines %
core/src/data/value/convert.rs 5 99.49%
core/src/executor/evaluate/mod.rs 7 97.99%
core/src/executor/evaluate/stateless.rs 15 94.34%
core/src/executor/aggregate/mod.rs 26 86.53%
Totals Coverage Status
Change from base Build 4486939346: -0.09%
Covered Lines: 40340
Relevant Lines: 40840
💛 - Coveralls

@panarch panarch changed the title Simplify JsonlStorage SortMerge next codes Simplify JsonlStorage codes Mar 25, 2023
devgony
devgony approved these changes Mar 25, 2023
View reviewed changes
Copy link
Collaborator

@devgony devgony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Incredibly simplified!

@panarch panarch merged commit 91d57c4 into main Mar 25, 2023
@panarch panarch deleted the nit-simplify-json-storage-sortmerge branch March 25, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ever0de ever0de ever0de approved these changes

@devgony devgony devgony approved these changes

Assignees

@panarch panarch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@panarch @coveralls @ever0de @devgony