Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge evaluate_stateless into evaluate, #1132

Merged
merged 12 commits into from
Apr 15, 2023

Conversation

panarch
Copy link
Member

@panarch panarch commented Mar 30, 2023

Add async to evaluate_stateless.
Rename existing evaluate to evaluate_inner which takes storage param as optional.
Make both evaluate and evaluate_stateless use evaluate_inner.
Remove stateless-only Context and merge that into RowContext.
Update JsonStorage and SledStorage to use nested async executor runtime using smol.

Add async to evaluate_stateless.
Rename existing evaluate to evaluate_inner which takes storage param as optional.
Make both evaluate and evaluate_stateless use evaluate_inner.
Remove stateless-only Context and merge that into RowContext.
Update JsonStorage and SledStorage to use nested async runtime using smol to handle evalute_stateless.
@panarch panarch added the improvement Improvements for existing features label Mar 30, 2023
@panarch panarch requested review from ever0de and devgony March 30, 2023 06:09
@panarch panarch self-assigned this Mar 30, 2023
@coveralls
Copy link

coveralls commented Mar 30, 2023

Pull Request Test Coverage Report for Build 4706829324

  • 328 of 353 (92.92%) changed or added relevant lines in 26 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 98.816%

Changes Missing Coverage Covered Lines Changed/Added Lines %
core/src/data/interval/string.rs 5 6 83.33%
core/src/data/row.rs 4 5 80.0%
core/src/executor/aggregate/mod.rs 3 4 75.0%
core/src/executor/insert.rs 37 38 97.37%
core/src/store/data_row.rs 7 8 87.5%
core/src/executor/alter/table.rs 12 14 85.71%
core/src/executor/aggregate/state.rs 30 33 90.91%
core/src/executor/select/mod.rs 44 47 93.62%
storages/sled-storage/src/store_mut.rs 91 94 96.81%
core/src/executor/context/row_context.rs 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
core/src/ast/mod.rs 1 99.83%
core/src/executor/validate.rs 1 99.24%
Totals Coverage Status
Change from base Build 4706806160: -0.02%
Covered Lines: 42216
Relevant Lines: 42722

💛 - Coveralls

core/src/executor/alter/table.rs Outdated Show resolved Hide resolved
core/src/executor/context/row_context.rs Outdated Show resolved Hide resolved
core/src/executor/evaluate/mod.rs Outdated Show resolved Hide resolved
core/src/executor/select/mod.rs Outdated Show resolved Hide resolved
storages/json-storage/Cargo.toml Outdated Show resolved Hide resolved
storages/sled-storage/Cargo.toml Outdated Show resolved Hide resolved
core/src/executor/evaluate/mod.rs Show resolved Hide resolved
Replace iter::repeat to vec![..].
Remove From<..> for RowContext and replace by adding methods to Row and DataRow.
@panarch panarch requested a review from ever0de April 8, 2023 08:47
@panarch panarch merged commit d087ab8 into main Apr 15, 2023
8 checks passed
@panarch panarch deleted the merge-evaluate-stateless-into-evaluate branch April 15, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements for existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants