-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge evaluate_stateless into evaluate, #1132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add async to evaluate_stateless. Rename existing evaluate to evaluate_inner which takes storage param as optional. Make both evaluate and evaluate_stateless use evaluate_inner. Remove stateless-only Context and merge that into RowContext. Update JsonStorage and SledStorage to use nested async runtime using smol to handle evalute_stateless.
Pull Request Test Coverage Report for Build 4706829324
💛 - Coveralls |
ever0de
requested changes
Apr 8, 2023
Replace iter::repeat to vec![..]. Remove From<..> for RowContext and replace by adding methods to Row and DataRow.
ever0de
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add async to evaluate_stateless.
Rename existing evaluate to evaluate_inner which takes storage param as optional.
Make both evaluate and evaluate_stateless use evaluate_inner.
Remove stateless-only Context and merge that into RowContext.
Update JsonStorage and SledStorage to use nested async executor runtime using smol.